Made the speed tie test use PASSES_RANDOMLY #5092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgriffin
reviewed
Aug 5, 2024
hedara90
added
the
category: battle-tests
mrgriffin
requested changes
Aug 13, 2024
include/test/battle.h
Outdated
| @@ -719,6 +719,7 @@ struct BattleTestRunnerState | |||
| u8 checkProgressParameter; | |||
| u8 checkProgressTrial; | |||
| u8 checkProgressTurn; | |||
| u32 occurenceCounter; | |||
There was a problem hiding this comment.
I'll have a think today about if there's something cleaner than adding a member to the test runner that's only used by one test.
Hack to allow results with PASSES_RANDOMLY
mrgriffin
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made the speed ties test utilize
PASSES_RANDOMLYinstead of a largePARAMETRIZE.This method utilizes the properties of the moves Endeavor, Super Fang, Crush Grip and Life Dew along with chosen max/starting HP value of the player Pokemon and chosen Atk/Def values to make calculation easier.
Final HP values of Mon1 and Mon2 were calculated manually then verified in the test runner after a setup had been finalized.
Discord contact info
hedara