Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AI Flags Documentation To Directory For New Documentation Site #5057

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

anrichtait
Copy link

Description

This pull request adds the file ai_flags.md to the /docs directory for the new documentation website.

Future contributions

I look forward to contributing to more documentation. Please let me know if this is the correct directory to add documentation to in the future.

Discord Contact Info

toonv#26526

Copy link
Collaborator

@AlexOn1ine AlexOn1ine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add somewhere at the top that generally it is recommended to use AI_FLAG_CHECK_BAD_MOVE, AI_FLAG_CHECK_VIABILITY, AI_FLAG_TRY_TO_FAINT for good AI. Everything else should be used with consideration

docs/ai_flags.md Outdated Show resolved Hide resolved
docs/ai_flags.md Outdated Show resolved Hide resolved
docs/ai_flags.md Show resolved Hide resolved
docs/ai_flags.md Outdated Show resolved Hide resolved
docs/ai_flags.md Show resolved Hide resolved
@AlexOn1ine
Copy link
Collaborator

Thanks for the changes. I'll wait for @Pawkkie for feedback before merging

@Pawkkie
Copy link
Collaborator

Pawkkie commented Jul 29, 2024

Thanks for the changes. I'll wait for @Pawkkie for feedback before merging

This looks good to me, I'll backport the changes to the wiki page once this gets merged.

My only piece of feedback is that I'm not sure "Keep in mind that this is a weaker form of AI_FLAG_TRY_TO_FAINT." is accurate when talking about AI_FLAG_STRONGEST_MOVE. Try To Faint has a more detailed clause for handling OHKOs, but doesn't handle 2HKOs at all. Strongest Move doesn't have as intelligent handling of OHKOs (it doesn't consider who's attacking first), but DOES handle 2HKOs.

If we want a comparative clause adding to that section, I might suggest something like "Keep in mind that this is weaker than AI_FLAG_TRY_TO_FAINT at scoring OHKOs" instead. @AlexOn1ine thoughts?

@AlexOn1ine
Copy link
Collaborator

Thanks for the changes. I'll wait for @Pawkkie for feedback before merging

This looks good to me, I'll backport the changes to the wiki page once this gets merged.

My only piece of feedback is that I'm not sure "Keep in mind that this is a weaker form of AI_FLAG_TRY_TO_FAINT." is accurate when talking about AI_FLAG_STRONGEST_MOVE. Try To Faint has a more detailed clause for handling OHKOs, but doesn't handle 2HKOs at all. Strongest Move doesn't have as intelligent handling of OHKOs (it doesn't consider who's attacking first), but DOES handle 2HKOs.

If we want a comparative clause adding to that section, I might suggest something like "Keep in mind that this is weaker than AI_FLAG_TRY_TO_FAINT at scoring OHKOs" instead. @AlexOn1ine thoughts?

Yeah, I like this suggestion

@Pawkkie Pawkkie added the type: documentation Improvements or additions to documentation label Jul 29, 2024
@anrichtait
Copy link
Author

Thanks for the changes. I'll wait for @Pawkkie for feedback before merging

This looks good to me, I'll backport the changes to the wiki page once this gets merged.

My only piece of feedback is that I'm not sure "Keep in mind that this is a weaker form of AI_FLAG_TRY_TO_FAINT." is accurate when talking about AI_FLAG_STRONGEST_MOVE. Try To Faint has a more detailed clause for handling OHKOs, but doesn't handle 2HKOs at all. Strongest Move doesn't have as intelligent handling of OHKOs (it doesn't consider who's attacking first), but DOES handle 2HKOs.

If we want a comparative clause adding to that section, I might suggest something like "Keep in mind that this is weaker than AI_FLAG_TRY_TO_FAINT at scoring OHKOs" instead. @AlexOn1ine thoughts?

Yeah, I like this suggestion

No problem I'll make the changes in the morning and also setup the new docs site on my local machine and create a new PR to add it there as well.

@anrichtait
Copy link
Author

That should be all the requested changes. Let me know if there's anything else. I have also started moving over the other documentation from the wiki which will be in a future PR.

@AlexOn1ine AlexOn1ine merged commit a89fc9d into rh-hideout:master Jul 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants