Changed EVO_OVERWORLD_STEPS to use an EWRAM variable #5047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed exploit that allowed PC swapping without resetting the step counter. |
Bassoonian
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed behavior of
EVO_OVERWORLD_STEPSin order to be more accurate with SV's mechanics:Also, added debug function to check both the step counter and the fishing chain value.
Images
Full showcase
Feature(s) this PR does NOT handle:
Does not implement SV's exploit. Technically in SV the counter doesn't reset until you take a step with a different mon, but this caused the side effect of allowing multiple Pokémon with a single set of steps, so probably wasn't intended.
Discord contact info
AsparagusEduardo