Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trainerproc: Support Ogerpon #5035

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

mrgriffin
Copy link
Collaborator

No description provided.

@mrgriffin mrgriffin requested a review from hedara90 July 25, 2024 13:51
@hedara90
Copy link
Collaborator

It might be out of scope for this PR, but here's how it behaves on Showdown.

  • If the base name is used, but it's holding a mask, it'll be treated as the form corresponding to the mask.
  • If the ability is incorrect for the form, it will error.
  • If the Tera type is incorrect for the form, it will overwrite it with the correct type.
  • If a form is specified by the name, and it's not holding the corresponding mask, it will error.

As it is right now everything works, but developers will have to be responsible for using correct forms with masks.
Approving unless you think this is in scope.

@mrgriffin
Copy link
Collaborator Author

So to confirm, everything works fine but Showdown has some additional checks and raises errors if the user specifies a combination of form/mask/Tera type that isn't legal? I think we're probably okay not to have those—I suppose a hack creator might actually want to have an Ogerpon with an "illegal" Tera type.

@kittenchilly
Copy link

I believe an illegal tera type on Ogerpon won't even work due to how we code it, it'll always use the tera type tied to the form

@hedara90 hedara90 merged commit a372035 into rh-hideout:upcoming Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants