Add Memento to AI_FLAG_RISKY #5032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The only thing that AI_FLAG_WILL_SUICIDE favours that AI_FLAG_RISKY doesn't is Memento, which should have been considered by Risky from the beginning and was an oversight when we were brainstorming Risky effects initially.
This adds Memento to Risky to functionally deprecate AI_FLAG_WILL_SUICIDE in time for the AI Flags poll. The scoring conditional is exactly the same as AI_FLAG_WILL_SUICIDE for now, we can consider tweaking it after the AI poll feedback, I just wanted to make sure it was included as is beforehand.
Tiny change also to use
aiData->hpPercents, which I was unaware of in the initial AI_FLAG_RISKY PR.Discord contact info
@Pawkkie