Reduces AI_WhoStrikesFirst to the most essential parts #4978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alex, could you check if the change is even worth it? I would suggest setting up a Double Battle and comparing the frames with and without your fix. You can use this macro to check https://github.com/rh-hideout/pokeemerald-expansion/blob/master/include/config/debug.h#L12 |
|
Discussed on discord bu for documentations sake. Improved by one frame. |
DizzyEggg
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most checks in
GetWhichBattlerFasterArgsare not relevant during ai calcs so I just copied the ones that are essential.Also I removed the randomness when there is a tie and made it so that the AI thinks it is faster. This will help with consistency in tests and I don't think it is that bad for AI to think it is slower in this case since the player risks a speed tie.