Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add B_ENEMY_THROW_BALLS, B_PLAYER_THROW_BALLS_SOUND, and B_ENEMY_THROW_BALLS_SOUND #4953

Merged
merged 10 commits into from
Jul 14, 2024
Merged

Add B_ENEMY_THROW_BALLS, B_PLAYER_THROW_BALLS_SOUND, and B_ENEMY_THROW_BALLS_SOUND #4953

merged 10 commits into from
Jul 14, 2024

Commits on Jul 11, 2024

  1. First proof of concept works

    @pkmnsnfrn
    pkmnsnfrn committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c4a6d08 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Added B_THROW_BALLS_SOUND

    @pkmnsnfrn
    pkmnsnfrn committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c2f5da0 View commit details
    Browse the repository at this point in the history

  2. Made generic MonSendOut

    @pkmnsnfrn
    pkmnsnfrn committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b164356 View commit details
    Browse the repository at this point in the history

  3. Changed magic number to constant

    @pkmnsnfrn
    pkmnsnfrn committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    5dfbcaa View commit details
    Browse the repository at this point in the history

  4. added acute e and changed to GEN_LATEST

    @pkmnsnfrn
    pkmnsnfrn committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    4752970 View commit details
    Browse the repository at this point in the history

  5. Removed tabs

    @pkmnsnfrn
    pkmnsnfrn committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    cbbe917 View commit details
    Browse the repository at this point in the history

  6. Undef'd HIBYTE and removed extra bool32

    @pkmnsnfrn
    pkmnsnfrn committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    9b66584 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. Made functions inline per https://github.com/rh-hideout/pokeemerald-e… 

    …xpansion/pull/4953/files\#r1675397114

Split into B_THROW_BALLS_SOUND B_PLAYER_THROW_BALLS_SOUND and B_ENEMY_THROW_BALLS_SOUND per https://github.com/rh-hideout/pokeemerald-expansion/pull/4953/files\#r1676143761
    @pkmnsnfrn
    pkmnsnfrn committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    e0ca421 View commit details
    Browse the repository at this point in the history

  2. Reset debug script

    @pkmnsnfrn
    pkmnsnfrn committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    3d51dba View commit details
    Browse the repository at this point in the history

  3. Removed static assert per Discord conversation with Alex

    @pkmnsnfrn
    pkmnsnfrn committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    88f8ddf View commit details
    Browse the repository at this point in the history