Refactors residual damage #4945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bassoonian
reviewed
Jul 11, 2024
AlexOn1ine
commented
Jul 11, 2024
AlexOn1ine
commented
Jul 11, 2024
AlexOn1ine
commented
Jul 11, 2024
|
Converting to draft because I noticed more scripts I would like to refactor |
AlexOn1ine
force-pushed
the
damageNonTypes
branch
from
cb79bad
to
ecf134d
Compare
|
Ready for review! I also refactored weather damage and added a simple animation for Ice Body heal that can be used anywhere else. |
AlexOn1ine
commented
Jul 13, 2024
Bassoonian
reviewed
Jul 13, 2024
AlexOn1ine
force-pushed
the
damageNonTypes
branch
from
a476f0e
to
39e4f61
Compare
Co-authored-by: Bassoonian <[email protected]>
Bassoonian
approved these changes
Jul 13, 2024
AlexOn1ine
added a commit
to AlexOn1ine/pokeemerald-expansion-1
that referenced
this pull request
Jul 17, 2024
Bassoonian
pushed a commit
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more readable and less prone to bugs