Minor AI flag fixes / cleanup

[Pawkkie]

Description

When writing up the AI flag document with psf and Alex, I stumbled across a few minor oversights that this PR address. This includes:

• Baton Pass score associated with AI_FLAG_PREFER_BATON_PASS did not consider any stat buffs the user has

  • Now adjusts score by (CountPositiveStatStages(battlerAtk) - CountNegativeStatStages(battlerAtk))

• The comment for AI_FLAG_DOUBLE_BATTLE is not accurate and should be replaced

  • Old: "removed, split between AI_FLAG_CHECK_BAD_MOVE & AI_FLAG_CHECK_GOOD_MOVE"
  • New: "Automatically set for double battles, handles AI behaviour with partner"

• AI_FLAG_HP_AWARE's handling of status moves at low HP could use a minor cleanup pass

  • EFFECT_LIGHT_SCREEN had negative score at lower HP but EFFECT_REFLECT did not; this was added
  • EFFECT_AURORA_VEIL had a negative score at lower HP, I believe Aurora Veil is generally best used if able regardless of HP, so this was removed

• AI_FLAG_WILL_SUICIDE doesn't consider Final Gambit and its comment says it does

  • Added a positive score modifier to Final Gambit with AI_FLAG_WILL_SUICIDE matching the flag's other behaviour

• AI_FLAG_CONSERVATIVE does not assume low rolls in switch calculations

  • This was an oversight when I added it initially, it has now been added

People who collaborated with me in this PR

Alex and psf through discussion

Discord contact info

@Pawkkie