-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AI_FLAG_SEQUENCE_SWITCHING #4878
Add AI_FLAG_SEQUENCE_SWITCHING #4878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
The requested changes are really nitpicks at this points, everything looks good.
Also about your worry here
I fully understand though that we're tight on AI flags and need to be discerning about what we choose to add.
I wouldn't worry about that, we could make it u64 instead of u32 and then you have additional 32 flags to work with.
Definitely thought this would mean a bitfield refactor, super good to know :D Ready for re-review! |
Description
Floated this in Discord the other day and didn't get a lot of traction one way or the other so I thought I'd PR it and we can discuss from here if need be.
Recently Kasen from the Aqua discord was asking me how hard it'd be to make a flag where:
This PR implements that functionality in
AI_FLAG_SEQUENCE_SWITCHING
. I can see five main utilities for a flag like this:I'm of the opinion that this is worth a flag slot as the behaviour is so radically different from existing AI flags, and it's applicable to niches that are not well served by existing flags. I fully understand though that we're tight on AI flags and need to be discerning about what we choose to add.
I've included tests to make sure the three intended features work correctly, as well as a safety net test to make sure this flag doesn't break forced random switching from Roar and effects like Dragon Tail.
People who collaborated with me in this PR
Kasen had the initial idea, psf came up with the flag name, and Egg had some helpful suggestions for overhauling some of the tests.
Discord contact info
@Pawkkie