Fix AI's right slot switching-in too early #4851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexOn1ine
reviewed
Jun 21, 2024
include/config/battle.h
Outdated
| #define B_MEGA_EVO_TURN_ORDER GEN_LATEST // In Gen7, a Pokémon's Speed after Mega Evolution is used to determine turn order, not its Speed before. | ||
| #define B_RECALC_TURN_AFTER_ACTIONS GEN_LATEST // In Gen8, switching/using a move affects the current turn's order of actions, better known as dynamic speed. | ||
| #define B_FAINT_SWITCH_IN GEN_LATEST // In Gen4+, sending out a new Pokémon after the previous one fainted happens at the end of the turn. Before, it would happen after each action. | ||
| #define B_FAIR_MULTI_SWITCH_IN_DOUBLES FALSE // In double trainer battles pokemon are switched at the same time, that is the player doesn't know the trainer's pokemon before they switch theirs. |
There was a problem hiding this comment.
Any reason this is set to false? Also are we sure we need a config for this since our doubles battles are already not gen3 compatible.
There was a problem hiding this comment.
Oops, this should be set to true lmao. I can get rid of the config
AlexOn1ine
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4656
I didn't have to do much, because the code functionality for this is already coded! In link battles, everyone chooses their switches and then the mons are switched-in, so this functionality is now also added for trainer double battles.
I created a new config, but can rename/delete it if you guys feel it's unnecessary.
I also got rid of the
Linklabel in scripts, since it'll no longer be used just for link battles.Note: Please squash when merging
Before:
After:
