Don't specify sDexSearchTypeOptions array size #4820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bassoonian
previously approved these changes
Jun 17, 2024
|
Approved too quickly, sorry. Any reason this shouldn't target master instead? |
Bug only happens on upcoming because of #4462 increasing |
|
That's fair, but "whenever a new non-conventional mon type is added" could theoretically happen to any hacker based of master adding their own custom types, right? |
|
I meant "non-conventional" as in a type that you wouldn't want displayed in the pokedex's search options, such as type NONE or Stellar but yes, it could happen. |
Bassoonian
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove pointless specified size that keeps breaking Pokedex search (image below) whenever a new non-conventional type is added.
Images
Discord contact info
duke5614