Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Pokémon Object Events from Following Pokémon functionality #4761

Conversation

AsparagusEduardo
Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo commented Jun 11, 2024

Description

Added error in case Followers are enabled but not their object events.

Let me know if I should change names such as followerData in gSpeciesInfo to account for the fact that they're no longer follower-exclusive.

Images

  • OW_POKEMON_OBJECT_EVENTS == TRUE and OW_FOLLOWERS_ENABLED == FALSE.
    mGBA_qkGyAaN8yS
  • OW_POKEMON_OBJECT_EVENTS == TRUE and OW_FOLLOWERS_ENABLED == TRUE.
    mGBA_4iqvhhSltK

Issue(s) that this PR fixes

Fixes #4726 .

Discord contact info

AsparagusEduardo

@Bassoonian
Copy link
Collaborator

Let me know if I should change names such as followerData in gSpeciesInfo to account for the fact that they're no longer follower-exclusive.

I would personally be inclined to ask for that change, yes

@Bassoonian Bassoonian merged commit 88028c0 into rh-hideout:upcoming Jun 13, 2024
1 check passed
@AsparagusEduardo AsparagusEduardo deleted the _RHH/pr/upcoming/splitObjEvents branch July 15, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The standardized overworld Pokémon artwork shouldn't be gated behind the follower feature.
2 participants