AI calculates/stores minimum possible move damage and uses it with AI_FLAG_TRY_TO_FAINT #4760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexOn1ine
reviewed
Jun 11, 2024
| normalDmg = CalculateMoveDamageVars(move, battlerAtk, battlerDef, moveType, fixedBasePower, | ||
| effectivenessMultiplier, weather, FALSE, | ||
| aiData->holdEffects[battlerAtk], aiData->holdEffects[battlerDef], | ||
| aiData->abilities[battlerAtk], aiData->abilities[battlerDef]); | ||
|
|
||
| critChanceIndex = CalcCritChanceStageArgs(battlerAtk, battlerDef, move, FALSE, aiData->abilities[battlerAtk], aiData->abilities[battlerDef], aiData->holdEffects[battlerAtk]); | ||
| if (critChanceIndex > 1) // Consider crit damage only if a move has at least +2 crit chance |
There was a problem hiding this comment.
Looks good but could you make a config for people who want to turn off crit calcs at plus two or lower?
Also unrelated to the config but right now I've noticed that if critChance is at +3 it will still calc as if it's the average. I think in this case it should be considered as it's always crit. Suggestion would be to check if critChance > 2 and assign -2 to it.
Sneed69
changed the title
AlexOn1ine
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is done in addition to the default damage calculations and designed to work alongside them.
The main purpose of this is to make the AI prefer a guaranteed KO move over the highest expected damage move.
I can imagine this increased flexibility being useful for more future AI features.
Discord contact info
duke5614