Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Shell Side Arm #4753

Merged
merged 7 commits into from
Jun 12, 2024
Merged

Conversation

AlexOn1ine
Copy link
Collaborator

@AlexOn1ine AlexOn1ine commented Jun 9, 2024

Fixes #1868

What a waste of cycles and nobody besides Skeli noticed 😅 (not that we shouldn't fix it)

@AlexOn1ine AlexOn1ine marked this pull request as draft June 9, 2024 22:01
@AlexOn1ine
Copy link
Collaborator Author

AlexOn1ine commented Jun 9, 2024

I can't figure out why the AI tests fail though it is also wrong ingame. What is weird about this is that we have plenty of similar AI tests that all pass

@AlexOn1ine AlexOn1ine marked this pull request as ready for review June 10, 2024 11:52
@AlexOn1ine
Copy link
Collaborator Author

I can't figure out why the AI tests fail though it is also wrong ingame. What is weird about this is that we have plenty of similar AI tests that all pass

ready for review

@AlexOn1ine
Copy link
Collaborator Author

@Skeli789 Ping in case you are interested to see how I've done it.

src/battle_ai_util.c Outdated Show resolved Hide resolved
src/battle_script_commands.c Show resolved Hide resolved
src/battle_util.c Outdated Show resolved Hide resolved
src/battle_ai_util.c Outdated Show resolved Hide resolved
src/battle_util.c Outdated Show resolved Hide resolved
src/battle_util.c Outdated Show resolved Hide resolved
@AlexOn1ine
Copy link
Collaborator Author

applied reviews.

@Bassoonian Bassoonian merged commit 9c72392 into rh-hideout:master Jun 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shell Side Arm not implemented correctly
3 participants