Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Pokémon Sprite Visualizer name official #4745

Merged

Conversation

Bassoonian
Copy link
Collaborator

With #4719 officially naming the Pokémon Debug menu (the one you open with select on the summary screen) the Pokémon Sprite Visualizer (see the readme on upcoming), this PR clarifies the name by renaming all the in-game assets to refer to the Pokémon Sprite Visualizer, allowing for disambiguation with the other debug menus and officially making the name canonical.

Discord contact info

bassoonian

@Bassoonian Bassoonian added this to the 1.9.0 milestone Jun 8, 2024
@AsparagusEduardo AsparagusEduardo self-assigned this Jun 8, 2024
include/constants/pokemon_sprite_visualizer.h Outdated Show resolved Hide resolved
include/pokemon_sprite_visualizer.h Outdated Show resolved Hide resolved
src/pokemon_sprite_visualizer.c Outdated Show resolved Hide resolved
@Bassoonian
Copy link
Collaborator Author

Feedback integrated

@AsparagusEduardo AsparagusEduardo merged commit bbc0523 into rh-hideout:upcoming Jun 9, 2024
1 check passed
@Bassoonian Bassoonian deleted the spritevisualisername branch July 27, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants