trainerproc documentation #4734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated the usage instructions for |
This was referenced Jul 14, 2024
|
This documentation looks and reads good to me. Is there anything else blocking this merge? (We should rename the PR since its just documentation now) |
I believe mgriffin wants the documentation part to be separate from |
mrgriffin
changed the title
mrgriffin
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile fix to Unicode issues in
trainers.partyDescription
Fixed some Unicode characters expanding into
U\xxxxxxxxwhen compiling the ROM by adding-traditional-cppto the command that runstrainerproc.Made error message more detailed when the
trainerprocencounters a character the ROM won't be able to display.Added some usage instructions to
trainers.party.Issue(s) that this PR fixes
Fixes #4531
People who collaborated with me in this PR
mrgriffin
Bassoonian
Discord contact info
hedara