Refactor move animations

[cawtds]

Description

Move animations are currently accessed via one large array, which needs to be sorted according to move ids. Ordering errors can easily go unnoticed due to the size of the array.
This PR removes the array and adds pointers to the animation scripts in gMovesInfo instead.

Discord contact info

.cawt

[AsparagusEduardo]

Something to test: What happens when battleAnimScript is unset.

[cawtds]

Something to test: What happens when battleAnimScript is unset.

Game freezes/gets stuck

[AlexOn1ine]

@AsparagusEduardo and @ghoulslash any more concerns?

[AsparagusEduardo]

any more concerns?

Two mainly:

• This is targetting master.
• Has the migration script been tested with someone's custom animations?

[AlexOn1ine]

Has the migration script been tested with someone's custom animations?

I was planning to test it with a custom move. It would be better if we asked someone with a lot of new moves though. Could someone ask Duke (I know they have a lot of new moves) or I do it later?

[AlexOn1ine]

This is targetting master

@cawtds could you retarget the pr to upcoming? Our workflow is that bugfixes go to master and new stuff to upcoming.

[AlexOn1ine]

Sorry @cawtds. One last thing. Could you add to the script to add this piece in moves_info.h:

#include "battle_anim_scripts.h"

[cawtds]

Sorry @cawtds. One last thing. Could you add to the script to add this piece in moves_info.h:

#include "battle_anim_scripts.h"

✔️

[AlexOn1ine]

Sorry... One more thing I'll promise to merge after it. 🙏

It seems const u8 *battleAnimScript isn't added to the move struct.

[cawtds]

Sorry... One more thing I'll promise to merge after it. 🙏

It seems const u8 *battleAnimScript isn't added to the move struct.

Not sure what you mean exactly. As part of the migration script or in general?

[AlexOn1ine]

Sorry... One more thing I'll promise to merge after it. 🙏
It seems const u8 *battleAnimScript isn't added to the move struct.

Not sure what you mean exactly. As part of the migration script or in general?

in the migration script. That one is missing there

[AsparagusEduardo]

Regarding adding #include "battle_anim_scripts.h" and const u8 *battleAnimScript via the migration script, I was wondering if it's actually needed, since those additions would be handled with the update merge done by the user (as far as I know). The only scenario I could think of is if they manually remove both when doing the merge.

[AlexOn1ine]

Regarding adding #include "battle_anim_scripts.h" and const u8 *battleAnimScript via the migration script, I was wondering if it's actually needed, since those additions would be handled with the update merge done by the user (as far as I know). The only scenario I could think of is if they manually remove both when doing the merge.

Yeah, that make sense. My bad.

[AlexOn1ine]

Regarding adding #include "battle_anim_scripts.h" and const u8 *battleAnimScript via the migration script, I was wondering if it's actually needed, since those additions would be handled with the update merge done by the user (as far as I know). The only scenario I could think of is if they manually remove both when doing the merge.

Yeah, that make sense. My bad.

Actually they would probably make it worse since it would be a duplicate.
My bad @cawtds could you please revert the last change I asked for? Was my bad.

[cawtds]

Regarding adding #include "battle_anim_scripts.h" and const u8 *battleAnimScript via the migration script, I was wondering if it's actually needed, since those additions would be handled with the update merge done by the user (as far as I know). The only scenario I could think of is if they manually remove both when doing the merge.

Yeah, that make sense. My bad.

Actually they would probably make it worse since it would be a duplicate. My bad @cawtds could you please revert the last change I asked for? Was my bad.

😢

[AsparagusEduardo]

Actually they would probably make it worse since it would be a duplicate. My bad @cawtds could you please revert the last change I asked for? Was my bad.

😢

Yeah, sorry about that, we shouldn't ping-ponging collaborators like this 😔

[cawtds]

Actually they would probably make it worse since it would be a duplicate. My bad @cawtds could you please revert the last change I asked for? Was my bad.

😢

Yeah, sorry about that, we shouldn't ping-ponging collaborators like this 😔

no worries, just saw it like 1 sec too late

[AsparagusEduardo]

Oh, before anyone merges, #4681 seems to have sneaked in because this PR it was based off master.

I have to go now, so someone please merge master into upcoming so that @cawtds can merge with upcoming and avoid having that PR's changes on this one.

[AsparagusEduardo]

Quickly came back to update upcoming with master, so just fixing conflicts should be needed before merge.