Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and clean up Battle Debug #4643

Merged
merged 9 commits into from
Jul 25, 2024

Conversation

kittenchilly
Copy link

@kittenchilly kittenchilly commented May 28, 2024

Description

The battle debug menu had quite a bit of missing flags in the bitfields you could edit, likely due to it not being updated when new stuff was added. I did that, going through all of them and adding any missing ones (but I didn't add some that just didn't work by flipping the bit).
I also restructured the code a bit, all ListMenuItem lists use enums now, which should make adding new flags easier.

Another thing is making it so the secondary list doesn't cut off early. This for example fixes the issues of the evasiveness stat stage changer noticeably cutting off, and also fixes some issues of longer names cutting off in Upcoming.

Discord contact info

kittenchilly

Copy link
Collaborator

@AlexOn1ine AlexOn1ine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't status mons anymore inside the debug menu

@kittenchilly
Copy link
Author

You can't status mons anymore inside the debug menu

It actually does apply the status but it doesn't update the graphics in the healthbox. I think its always been like that, but I can fix it anyways

@kittenchilly
Copy link
Author

Oh, I just realized it was because I removed a line saving the status accidentally. Fixed.

@AlexOn1ine
Copy link
Collaborator

Most of the status3 stuff doesn't seem to work or they work but the behavior is weird. E.g. If you Leech Seed a mon it drains health from itself and gets it back.

@kittenchilly
Copy link
Author

Most of the status3 stuff doesn't seem to work or they work but the behavior is weird. E.g. If you Leech Seed a mon it drains health from itself and gets it back.

Can you make a list of stuff that doesn't seem to work at all so I can remove it? Also if something does seem to do something but doesn't seem right, maybe I can try to fix it

@AlexOn1ine
Copy link
Collaborator

AlexOn1ine commented Jun 29, 2024

Most of the status3 stuff doesn't seem to work or they work but the behavior is weird. E.g. If you Leech Seed a mon it drains health from itself and gets it back.

Can you make a list of stuff that doesn't seem to work at all so I can remove it? Also if something does seem to do something but doesn't seem right, maybe I can try to fix it

Please remove the following

Uproar
Bide
Multiple Turns
Lock Confuse
Wrapped
Infatuation
Transformed
Substitute
Nightmare
Trace
Me First
Phantom Force
Infinite Confusion
Sky Dropped
Future Attack

Everything else is good

@kittenchilly
Copy link
Author

Finally got around to fixing this

@AlexOn1ine
Copy link
Collaborator

Can you just remove them from the debug menu?

@kittenchilly
Copy link
Author

Can you just remove them from the debug menu?

I did, they don't appear.

@AlexOn1ine
Copy link
Collaborator

AlexOn1ine commented Jul 14, 2024

Can you just remove them from the debug menu?

I did, they don't appear.

the code is still there and for most of them it isn't functional. I don't see a reason to keep the code. We can always add it back when we decide that it makes sense to have it for something.

@kittenchilly
Copy link
Author

Can you just remove them from the debug menu?

I did, they don't appear.

the code is still there and for most of them it isn't functional. I don't see a reason to keep the code. We can always add it back when we decide that it makes sense to have it for something.

Ok, done

@AlexOn1ine AlexOn1ine merged commit a16448c into rh-hideout:master Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants