Fix held item names in the PC sometimes using the shorter font when unnecessary #4588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bassoonian
approved these changes
May 16, 2024
|
Does this test need updating too? |
Oh, it might? I didn't know it existed, my bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed the name of some held items on pokemon in the PC switched to using the shorter font, when the item name is the same as vanilla (not expanded). This fixes that by making the width it checks the same as the pokemon species name, as its more than enough to fit within the box, and it was really limiting before.
Images
(Mystic Water is a vanilla name and is not expanded)
Before:
After:
Discord contact info
kittenchilly