Get rid of gItemIconTable #4579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexOn1ine
approved these changes
May 18, 2024
AlexOn1ine
added a commit
to AlexOn1ine/pokeemerald-expansion-1
that referenced
this pull request
May 18, 2024
Bassoonian
pushed a commit
that referenced
this pull request
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Much like the change with the item descriptions a bit ago, this makes it so that defining the sprite and palette for an item icon is part of Item data directly instead of being one big separate list.
Also included is a migration script that automatically transfers items from item_icon_table.h to the new format in items.h. Vanilla items have already been migrated, as such item_icon_table.h has been blanked out.
Discord contact info
kittenchilly