-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FORM_CHANGE_BATTLE_TERASTALLIZATION + allow species to force tera types #4438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree that forced Tera Types should be allowed to be changed after being generated. The forced Tera type field itself should signify that you cannot change the type.
Addressed all reviews |
I didn't notice this comment until after I addressed the reviews but doing this would be a lot easier |
It actually isn't easier apparently, a bunch of tests start failing if I force it through GetTeraType or GetMonData. It works fine how it is right now so I think we should leave it be. Might even be more accurate to the games this way |
I think this is because of the type order. I think we need to address this before this PR. |
I actually figured out how to fix it, and it forces it properly. |
Actually, I won't make P_SHOW_TERA_TYPE GEN_LATEST until we add unique tera type icons for it, which will be a separate PR. |
Ready to re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to add a test to confirm that species is being changed upon Terastallization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kitten since the forms will be functional with this can you please write tests for #4454?
Addressed all reviews again. This should fix #4454 now as well. |
Tests added for Tera Starstorm
Description
Adds FORM_CHANGE_BATTLE_TERASTALLIZATION , which happens upon terastallization and requires the pokemon to be the defined tera type in order to change to that form. Form tables have also been updated with this.
Also adds forceTeraType to species, which will make any pokemon of that species or form always use that tera type. Terapagos and Ogerpon properly force the correct tera types with this, and Ogerpon's tera type properly changes when changing between its forms.
Discord contact info
kittenchilly