Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine weather set commands #4434

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

AlexOn1ine
Copy link
Collaborator

@AlexOn1ine AlexOn1ine commented Apr 23, 2024

Combines weather commands into Cmd_setfieldweather:

Cmd_setrain
Cmd_setsunny
Cmd_sethail
Cmd_setsandstorm
BS_SetSnow

@AlexOn1ine AlexOn1ine changed the title Combine Weather set commands Combine weather set commands Apr 23, 2024
@AsparagusEduardo
Copy link
Collaborator

I need to look better bc I'm on mobile, but doesn't Snow and Hail also fail to be set if Primordial Sea is active? If so, we need tests for those as well (+ Sandstorm for both primal weathers)

Besides that, looks good :)

@AlexOn1ine
Copy link
Collaborator Author

AlexOn1ine commented Apr 24, 2024

I need to look better bc I'm on mobile, but doesn't Snow and Hail also fail to be set if Primordial Sea is active? If so, we need tests for those as well (+ Sandstorm for both primal weathers)

Besides that, looks good :)

Yeah it does. I didn't write a test because I thought it might be redundant since I already wrote one for Desolate Land but if you think they are important I can add them.

/Edit: Added 😅

test/battle/weather/hail.c Outdated Show resolved Hide resolved
test/battle/weather/snow.c Outdated Show resolved Hide resolved
@AsparagusEduardo AsparagusEduardo merged commit 6f538d8 into rh-hideout:upcoming Apr 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants