Change Battle Frontier validation to species flag

[kittenchilly]

Description

EDIT by Edu: This PR adds isFrontierBanned instead of splitting the legendary flag in two.

I split the isLegendary flag into 2 flags that more closely respect how Pokemon are flagged in the games: isRestrictedLegendary and isSubLegendary.
These can be used for any custom stuff but without any of that currently they are used for:
isRestrictedLegendary must have 3 perfect IVs, and additionally can't be used in the Battle Frontier.
isSubLegendary must have 3 perfect IVs.

With this change, I also updated the Battle Frontier validity check to use the isRestrictedLegendary and isMythical flags isFrontierBanned flag for if a mon should be banned, rather than a separate hardcoded array. This should make updating the banlist easier, and also consequently fixes Terapagos and Pecharunt not being banned.

Also renamed isParadoxForm to isParadox since they aren't forms, and removed the isParadox flag from Koraidon and Miraidon since they are just legendaries.

Discord contact info

kittenchilly

[AlexOn1ine]

doesn't compile on modern.

[kittenchilly]

Reviews addressed and modern fixed

[kittenchilly]

Reviews addressed again, should be fast now without using a hardcoded list

[AsparagusEduardo]

Reviews addressed again, should be fast now without using a hardcoded list

"Should be"? I guess I gotta test it in-game myself if you aren't.

[AsparagusEduardo]

"Should be"? I guess I gotta test it in-game myself if you aren't.

Sorry if this was too mean. After what happened with #4373, I got a bit on edge about not testing code that theorically works.

[kittenchilly]

"Should be"? I guess I gotta test it in-game myself if you aren't.

Sorry if this was too mean. After what happened with #4373, I got a bit on edge about not testing code that theorically works.

It's ok. I actually did test it and thought it was faster but I just wanted other people to judge for themselves, I guess. Sorry for the confusing language

[AsparagusEduardo]

Forgot to remove the isMythical from the frontier functions ^^;

[kittenchilly]

Forgot to remove the isMythical from the frontier functions ^^;

Done

[AsparagusEduardo]

Done

Lol, I was about to do that too 😂