Updated Knock Off #4333
Merged
Updated Knock Off #4333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgustinGDLV
force-pushed
the
pr/knock_off
branch
from
e13e043
to
ea08111
Compare
|
Agustin, could you include an item check in the tests at the end? See White Herb tests. |
AgustinGDLV
force-pushed
the
pr/knock_off
branch
from
ea08111
to
a1f7cf4
Compare
|
How does that look? Ignore my messed up git history lol |
Isn't there an expect missing |
AlexOn1ine
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Gen 5+, Knock Off removes the item from the target altogether, as opposed to making it unusable. This updated behavior allows for Knocked Off targets to gain another item later in the battle. Otherwise, it is almost entirely aesthetic as other edge cases seem unaffected: Unburden seems to trigger from Knock Off in Gen 4 and Symbiosis never triggers after Knock Off.
This PR adds more tests for Knock Off's basic interactions, this updated behavior, and some other small edge cases.
Images
Gen 3 and 4:
https://github.com/rh-hideout/pokeemerald-expansion/assets/103095241/02afedb3-6c3a-4694-ac75-9ad16b905769
Gen 5+:
https://github.com/rh-hideout/pokeemerald-expansion/assets/103095241/787e48ae-305b-4efe-a380-83ece229565e
Issue(s) that this PR fixes
Fixes #1903 (wow that's old)
People who collaborated with me in this PR
Thanks @AlexOn1ine and @Bassoonian for reminding me to update my old PR.
Discord contact info
agustingdlv