Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evolution method for Gimmighoul, EVO_LEVEL_ITEM_COUNT_999 #4261

Merged
merged 9 commits into from
Mar 17, 2024

Conversation

kittenchilly
Copy link

@kittenchilly kittenchilly commented Mar 9, 2024

Description

Adds the evo method for Gimmighoul; if you have 999 Gimmighoul coins in the bag and level up, your Gimmighoul evolves into Gholdengo and removes the 999 coins. You can set EVO_LEVEL_ITEM_COUNT_999 to require 999 of any item for custom evolutions as well.
This evolution method is a bit unique, as it prevents you from stopping it since, if you could, it'd scam you out of all your coins. Because of this, I had to add a new evo mode alongside it, EVO_MODE_CANT_STOP, which is just EVO_MODE_NORMAL, but it doesn't let you stop the evolution. This might be useful for more stuff later on as well.

Feature(s) this PR does NOT handle:

Config option perhaps to allow stopping the evo but refunding the coins, which would be pretty hard to do (and is not how it works officially)

Discord contact info

kittenchilly

@AlexOn1ine
Copy link
Collaborator

EVO_LEVEL_COLLECT_999 maybe a different name, something like EVO_LEVEL_ITEM_COUNT_999?

@kittenchilly
Copy link
Author

EVO_LEVEL_COLLECT_999 maybe a different name, something like EVO_LEVEL_ITEM_COUNT_999?

I followed what it was called in SV's data (LevelUpCollect999) but I guess we can change it.

@AlexOn1ine
Copy link
Collaborator

EVO_LEVEL_COLLECT_999 maybe a different name, something like EVO_LEVEL_ITEM_COUNT_999?

I followed what it was called in SV's data (LevelUpCollect999) but I guess we can change it.

I feel like Collect999 doesn't say much so I would prefer something different. I'm pretty sure we deviated on a lot of labels so this shouldn't be a problem.

@LOuroboros
Copy link
Collaborator

LOuroboros commented Mar 11, 2024

EVO_LEVEL_ITEM_COUNT_999 sounds good to me too. It makes it clear that the evo method acts if the Player has 999 copies of the specified item to me.

src/party_menu.c Outdated Show resolved Hide resolved
@kittenchilly kittenchilly changed the title Add evolution method for Gimmighoul, EVO_LEVEL_COLLECT_999 Add evolution method for Gimmighoul, EVO_LEVEL_ITEM_COUNT_999 Mar 11, 2024
@kittenchilly
Copy link
Author

EVO_LEVEL_ITEM_COUNT_999 sounds good to me too. It makes it clear that the evo method acts if the Player has 999 copies of the specified item to me.

Alright

src/party_menu.c Outdated Show resolved Hide resolved
@kittenchilly
Copy link
Author

Should be reviewable again.

@AlexOn1ine
Copy link
Collaborator

Can't use the item
pokeemerald-49

@kittenchilly
Copy link
Author

Can't use the item pokeemerald-49

You don't use the item...
You level up while having 999 in your bag.

Copy link
Collaborator

@AlexOn1ine AlexOn1ine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 things and then it can be merged 😅

src/pokedex_plus_hgss.c Outdated Show resolved Hide resolved
include/constants/pokemon.h Outdated Show resolved Hide resolved
@kittenchilly
Copy link
Author

Addressed the comments

@AlexOn1ine AlexOn1ine merged commit 9202896 into rh-hideout:upcoming Mar 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants