-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add evolution method for Gimmighoul, EVO_LEVEL_ITEM_COUNT_999 #4261
Conversation
|
I followed what it was called in SV's data (LevelUpCollect999) but I guess we can change it. |
I feel like Collect999 doesn't say much so I would prefer something different. I'm pretty sure we deviated on a lot of labels so this shouldn't be a problem. |
|
Alright |
Should be reviewable again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 things and then it can be merged 😅
Addressed the comments |
Description
Adds the evo method for Gimmighoul; if you have 999 Gimmighoul coins in the bag and level up, your Gimmighoul evolves into Gholdengo and removes the 999 coins. You can set EVO_LEVEL_ITEM_COUNT_999 to require 999 of any item for custom evolutions as well.
This evolution method is a bit unique, as it prevents you from stopping it since, if you could, it'd scam you out of all your coins. Because of this, I had to add a new evo mode alongside it, EVO_MODE_CANT_STOP, which is just EVO_MODE_NORMAL, but it doesn't let you stop the evolution. This might be useful for more stuff later on as well.
Feature(s) this PR does NOT handle:
Config option perhaps to allow stopping the evo but refunding the coins, which would be pretty hard to do (and is not how it works officially)
Discord contact info
kittenchilly