forked from DizzyEggg/pokeemerald
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Official GF names by default #4241
Merged
AsparagusEduardo
merged 13 commits into
rh-hideout:upcoming
from
mrgriffin:rhh-narrower-font-long-move-names
Apr 25, 2024
Merged
Official GF names by default #4241
AsparagusEduardo
merged 13 commits into
rh-hideout:upcoming
from
mrgriffin:rhh-narrower-font-long-move-names
Apr 25, 2024
Commits on Apr 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 62ce29d - Browse repository at this point
Copy the full SHA 62ce29dView commit details -
PARAMETRIZE_LABEL in test/species.c
PARAMETRIZE_LABEL is like PARAMETRIZE, except that it allows the user to provide a label which will be displayed in the test name line. This is useful for tracking _which_ PARAMETRIZE case failed in the situation where the numbers are unwieldy.
Configuration menu - View commit details
-
Copy full SHA for 1fea6b8 - Browse repository at this point
Copy the full SHA 1fea6b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e42a0a6 - Browse repository at this point
Copy the full SHA e42a0a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 738fade - Browse repository at this point
Copy the full SHA 738fadeView commit details -
Enable GF move names by default
In contests, even FONT_NARROWER isn't sufficient to prevent clipping in all cases. e.g. Stomping Tantrum clips. We have decided to accept that cost to make the rest of the user experience better, but downstream projects that don't like that trade-off can either a) alter the contest UI, or b) set B_EXPANDED_MOVE_NAMES to FALSE.
Configuration menu - View commit details
-
Copy full SHA for a1d2460 - Browse repository at this point
Copy the full SHA a1d2460View commit details -
Configuration menu - View commit details
-
Copy full SHA for 484e288 - Browse repository at this point
Copy the full SHA 484e288View commit details -
Enable GF item names by default
In the Pokémon Storage System, even FONT_SMALL_NARROWER isn't sufficient to prevent clipping in all cases. e.g. Unremarkable Teacup clips. We have decided to accept that cost to make the rest of the user experience better, but downstream projects that don't like that trade-off can either a) alter the Pokémon Storage System UI, or b) set I_EXPANDED_ITEM_NAMES to FALSE.
Configuration menu - View commit details
-
Copy full SHA for aab9678 - Browse repository at this point
Copy the full SHA aab9678View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ec3554 - Browse repository at this point
Copy the full SHA 2ec3554View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06d817b - Browse repository at this point
Copy the full SHA 06d817bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d913792 - Browse repository at this point
Copy the full SHA d913792View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30efba0 - Browse repository at this point
Copy the full SHA 30efba0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 073f12b - Browse repository at this point
Copy the full SHA 073f12bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 664fe90 - Browse repository at this point
Copy the full SHA 664fe90View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.