Rename EFFECT_FAKE_OUT to EFFECT_FIRST_TURN_ONLY

[AlexOn1ine]

Renamed EFFECT_FAKE_OUT to EFFECT_FIRST_TURN_ONLY to more reflect it's use. Also changed AI logic slightly to differentiate between fake out and first impression.

[AsparagusEduardo]

Hang on, mechanically, what are the main differences between the two? I was under the impression (heh.) that First Impression was a more powerful Fake Out.

[AlexOn1ine]

Hang on, mechanically, what are the main differences between the two? I was sure that First Impression was a more powerful Fake Out.

First Impression doesn't flinch

[AsparagusEduardo]

First Impression doesn't flinch

Then wouldn't that fall under additionalEffects for Fake Out?

[AlexOn1ine]

First Impression doesn't flinch
Then wouldn't that fall under additionalEffects for Fake Out?

No, not necessarily. 100% flinching is a strong effect which imo deserves it's own case. Otherwise it would never be chosen because of weak power. Similarly First Impression has 90 BP and should if possible be preferred over other moves with a similar power and because it has higher priority.

[AsparagusEduardo]

No, not necessarily. 100% flinching is a strong effect which imo deserves it's own case. Otherwise it would never be chosen because of weak power. Similarly First Impression has 90 BP and should if possible be preferred over other moves with a similar power and because it has higher priority.

Ah, this is for AI.

I disagree completely, the AI should be adjusted instead so that it considers the 100% flinch instead of fragmenting the data into more effects.

[AlexOn1ine]

No, not necessarily. 100% flinching is a strong effect which imo deserves it's own case. Otherwise it would never be chosen because of weak power. Similarly First Impression has 90 BP and should if possible be preferred over other moves with a similar power and because it has higher priority.

Ah, this is for AI.

I disagree completely, the AI should be adjusted instead so that it considers the 100% flinch instead of fragmenting the data into more effects.

Without some major rewrite this isn't possible. Fake Out and First Impression need an effect because they always fail from the 2nd turn on wards. Additionally Fake out has a Priority of 3. This sets it's apart from other flinch effect moves. Also moves with 100% chance to flinch are already handled in AI_CalcMoveScore.

[cfmnephrite]

I think this could do with a rethink. With additional effects, they unambiguously have the same effect i.e. "fail if not first turn".

Hence, both moves need to run a lot of the same checks in ShouldFakeOut - the problem is that Fake Out has an additional check for Inner Focus but this should no longer be the case. Both moves should have the exact same check for first turn or not, then the additional check for any additional effects (code for which is already implemented). Otherwise you're taking a step back by giving moves their own unique effects again.

[AlexOn1ine]

Hence, both moves need to run a lot of the same checks in ShouldFakeOut

No, they have different checks from each other. First Impression should never check ShouldFakeOut because non of the conditions apply there.

I disagree that it's a step back. Some move effects are unique and need to be distinguished from each other. Also a lot of those moves have negative side effects which we somehow need to signal to the AI

[AlexOn1ine]

I think this could do with a rethink

I'm open for suggestions but we either have to keep the hardcode check for First Impression or make a new effect for it.

/Edit: A different idea would be to add an argument to First Impression to filter out the fake out effect. In that case we should rename EFFECT_FAKE_OUT.

[AlexOn1ine]

Changed EFFECT_FAKE_OUT to EFFECT_FIRST_TURN_ONLY, removed the new first impression effect to keep using the now new named effect and added an argument to differentiate both moves in AI_CalcMoveScore.

[AlexOn1ine]

I think its unique combination of priority, effect and additional effects makes

Main concern is that we need to signal the AI that those moves fail on the second turn. If it wasn't for that we would be able to handle it without the effect.

[AsparagusEduardo]

Can you please add the other changes you did to the PR description since it's not just Fake Out/First Impression? Besides that and the script rename, lgtm.

[AlexOn1ine]

Can you please add the other changes you did to the PR description since it's not just Fake Out/First Impression? Besides that and the script rename, lgtm.

changed

[AsparagusEduardo]

I was about to say approve, but found one more thing, sorry D:

[AsparagusEduardo]

Approved, though about the remove useful comment, I removed it because we're never going to assign TV points for to the placeholder effect ^^;