Moved Item Effects to gItems #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bassoonian
reviewed
Jan 14, 2024
| @@ -36,20 +36,12 @@ const u8 gItemEffect_MaxPotion[7] = { | |||
|
|
|||
| const u8 gItemEffect_HyperPotion[7] = { | |||
| [4] = ITEM4_HEAL_HP, | |||
There was a problem hiding this comment.
Out of scope for this PR obviously, but I really feel like the array indices should not be magic numbers supported by a comment and rather be easier through use through defines or macros or something
There was a problem hiding this comment.
If someone is able to do so, they should PR it to pret :)
Bassoonian
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also removed some redundant item effects.
Feature(s) this PR does NOT handle:
Does not refactor the item effect system, just moves where the data is obtained.
Discord contact info
AsparagusEduardo