Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ITEMS_COUNT and ITEM_NAME_LENGTH to RHH rom header #3988

Merged
merged 12 commits into from
Jan 21, 2024

Conversation

Ninjdai1
Copy link

@Ninjdai1 Ninjdai1 commented Jan 13, 2024

Description

There was no way for an external program to access the ITEMS_COUNT or ITEM_NAME_LENGTH.
This PR adds ITEMS_COUNT and ITEM_NAME_LENGTH to the RHH rom header*

Discord contact info

ninjdai

There was no way for an external program to access the ITEMS_COUNT.
@Ninjdai1 Ninjdai1 marked this pull request as draft January 13, 2024 14:39
@Ninjdai1 Ninjdai1 changed the title Add ITEMS_COUNT to RHH rom header Add ITEMS_COUNT and ITEM_NAME_LENGTH to RHH rom header Jan 13, 2024
@Ninjdai1 Ninjdai1 marked this pull request as ready for review January 13, 2024 14:45
src/rom_header_rhh.c Outdated Show resolved Hide resolved
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
src/rom_header_rhh.c Outdated Show resolved Hide resolved
@AsparagusEduardo AsparagusEduardo merged commit 7ba3f53 into rh-hideout:upcoming Jan 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants