Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed some hardcoded move IDs #3982

Conversation

AsparagusEduardo
Copy link
Collaborator

Description

Replaces #3954

  • Removed hardcoding for:
    • MOVE_EXPLOSION
    • MOVE_SELF_DESTRUCT
    • MOVE_FRUSTRATION
    • MOVE_AURA_WHEEL
    • MOVE_PRESENT
  • Removed EFFECT_HURRICANE in favor of using EFFECT_THUNDER.
  • Added EFFECT_BLIZZARD.
  • Added EFFECT_RAIN_ALWAYS_HIT for Forces of Nature moves.
  • Renamed constants/z_move_effects.h to constants/battle_z_move_effects.h
  • Added includes to src/data/battle_moves.h so that newbies don't worry about fake IDE errors.

Feature(s) this PR does NOT handle:

I was going to remove more hardcoded IDs, but I ran out of hands for the day ^^;

Discord contact info

AsparagusEduardo

Copy link
Collaborator

@AlexOn1ine AlexOn1ine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was confused for a second because I couldn't find the move defines lol.

Good changes!

@AlexOn1ine AlexOn1ine merged commit ff0aed3 into rh-hideout:upcoming Jan 12, 2024
1 check passed
@AsparagusEduardo AsparagusEduardo deleted the _RHH/pr/upcoming/moveEffectCleanup branch January 13, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants