Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed oversight causing chosen fossil to be lost if bag is full #3978

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

fakuzatsu
Copy link

Description

If bag is full and expansion configs are set as default, the chosen fossil will be lost upon selecting it, as there is no check to ensure it went into your regular items pocket.

Discord contact info

Zatsoo

@AsparagusEduardo
Copy link
Collaborator

I don't even think we even need the ifs, since that could also technically happen to the Key Items pocket 👀
Even if it wouldn't happen in vanilla, it's still a nice failsafe :)

@ZnogyroP
Copy link

Change should also be made to the Desert Underpass, since the same thing can happen there

@AsparagusEduardo
Copy link
Collaborator

Change should also be made to the Desert Underpass, since the same thing can happen there

Good point!

@Bassoonian Bassoonian merged commit cae58ca into rh-hideout:master Jan 17, 2024
1 check passed
@fakuzatsu fakuzatsu deleted the fossil-fix branch February 2, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants