Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pokemon GFX Upgrades/Fixes #3805

Merged
merged 11 commits into from
Dec 30, 2023
Merged

Conversation

katykat5099
Copy link

@katykat5099 katykat5099 commented Dec 22, 2023

Description

Upgrades / Fixes to Pokemon Species sprites

Images

todo

Issue(s) that this PR fixes

Fixes #3772
Fixes #3613
Fixes #3553

Discord contact info

Kakariki

@katykat5099 katykat5099 changed the title Tyrantrum GFX Upgrade Pokemon GFX Upgrades/Fixes Dec 22, 2023
missing pixel
For rh-hideout#3553
Did a bunch of research (looking at how old icons generally look) to help decide specific icons to choose from.
Generally icons are more 'chibi' like, with large heads (exceptions being 'scary' fully evolved pokemon) and the animations usually move up and down with some character.
Some touches as well.
Missing Pixel
@Jaizu
Copy link

Jaizu commented Dec 26, 2023

tyrantrum backsprite should have the shiny palette loaded

@Bassoonian
Copy link
Collaborator

If you include "Fixes" before each issue number, they'll automatically get marked as resolved when the PR gets approved :)

@katykat5099
Copy link
Author

katykat5099 commented Dec 30, 2023

tyrantrum backsprite should have the shiny palette loaded

Thanks, will fix. Must've forgot to change it back.
btw, is there a way to get notifications sent to mobile? I didn't see these comments and just stumbled upon them now.

I figured it out on my iPad at least.

@Jaizu
Copy link

Jaizu commented Dec 30, 2023

I personally get them by mail, not sure about git clients o7

Switch to shiny pal on Tyrantrum’s back sprite png
@katykat5099
Copy link
Author

Alright, I changed it to the shiny sprite.

I can set it up for review, and I'll just pr again, I've got a list but they're almost all harder ones to do.
And I like to do it when I have fun doing it. lol

One thing though, shouldn't it be going to upcoming or is this one, since its minor changes, fine to go to master?

@Bassoonian
Copy link
Collaborator

All the fixes should definitely go to master. I think the upgrades are technically better suited for upcoming, if you don't mind splitting the PR for that :)

@AlexOn1ine
Copy link
Collaborator

All the fixes should definitely go to master. I think the upgrades are technically better suited for upcoming, if you don't mind splitting the PR for that :)

I think it's fine if all goes to master. 😅
The PR is simple enough.

@katykat5099 katykat5099 marked this pull request as ready for review December 30, 2023 18:59
@Bassoonian Bassoonian merged commit 00e7038 into rh-hideout:master Dec 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants