Battlemove refactored fixes #3779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced ALWAYS_CRIT with an alwaysCriticalHit flag to account for the fact that in earlier generations, there is no crit stage at which crits are guaranteed. Renamed critBoost to criticalHitStage (at Edu's prompting). Reorder .criticalHitStage defines in battle_moves.h to be aligned with struct order.
Bassoonian
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
ALWAYS_CRIToversight in previous Battlemove refactored PR plus a few tweaksDescription
critBoosttocriticalHitStageALWAYS_CRITdefine - +3criticalHitStageno longer assumed to always crit (thanks to previous gen mechanics)alwaysCriticalHitflag to replace definecritBoost == ALWAYS_CRITwithalwaysCriticalHit == TRUEwhere necessaryBattleMovestruct - movedcriticalHitStageto appropriate location in relevant moves inbattle_moves.hIssue(s) that this PR fixes
Fixed #3771
Discord contact info
Cancer Fairy/thechurchofcage