Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Pokédex texts for forms #3708

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

Bassoonian
Copy link
Collaborator

Adds the missing Pokédex descriptions and updates the base form's if necessary. Everything should fit (the same script was used for the descriptions of the Gen9 mons, and I don't remember any inaccuracies there), but double checking would be appreciated.

Issue(s) that this PR fixes

Fixes #3650

Discord contact info

bassoonian

Copy link
Collaborator

@AlexOn1ine AlexOn1ine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but why the random changes in some existing entries?

src/data/pokemon/species_info.h Show resolved Hide resolved
src/data/pokemon/species_info.h Show resolved Hide resolved
Comment on lines -43109 to +43328
"It is said to carry wandering spirits to\n"
"the place where they belong so they can\n"
"move on. As the sun sets, it becomes\n"
"restless and active."),
"The light that streams out from\n"
"the holes in the pumpkin can\n"
"hypnotize and control the people and\n"
"Pokémon that see it."),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Not sure if this is good or bad. I guess there isn't a rule for what desc. will be used?

Copy link
Collaborator

@AlexOn1ine AlexOn1ine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now that the new desc. are because of multiply forms, thx.

@AlexOn1ine AlexOn1ine merged commit 75b45a9 into rh-hideout:upcoming Dec 12, 2023
1 check passed
@Bassoonian Bassoonian deleted the dextexts branch December 27, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants