-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update catch curve for pokeballs #3685
Conversation
1e87ff2
to
5968b94
Compare
Can you link a source? |
Can you stop with all the force pushing as previously asked? There is no need for a PR this simple to have all these force pushes in its history and it makes reviewing harder than it has to be. |
https://www.dragonflycave.com/mechanics/gen-vi-vii-capturing#throwing-a-ball sounds like the reason for this change. |
Bulbapedia. However, because the power in question is a decimal value, I refactored it so that it's 65536/(a^(3/16)), which is a tiny modification of the method but it allows me to do sqrt 4 times a cubed, which has rounding errors sure but it's the best I could do without delving into floating point madness. |
Where is |
Wolfram alpha when I was making approximations. |
But how though? |
Since Gen 6, the capture rate curve was changed to make pokeballs more effective on lower level pokemon It's by 65536 divided by 255 to the power of(1/5.33) and I did the work of translating that so a rough approximation can be done in integers, and so far, it seems to work close enough. I use this in my romhack for months now and it works fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you make a PR like that in the future please provide a source and explain your process.
This reverts commit 929ec54.
Since Gen 6, the capture rate curve was changed to make pokeballs more effective on lower level pokemon
It's by 65536 divided by 255 to the power of (1/5.33) and I did the work of translating that so a rough approximation can be done in integers, and so far, it seems to work close enough. I use this in my romhack for months now and it works fine.
Discord contact info
roseareazero