Fixed Fusion memory leak #3644
Merged
Fixed Fusion memory leak #3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
loops should be u32 instead of u8 because why not |
Bassoonian
approved these changes
Dec 8, 2023
Closed
PCG06
pushed a commit
to PCG06/pokeemerald
that referenced
this pull request
Dec 8, 2023
* Fixed Fusion memory leak * using u32 --------- Co-authored-by: Bassoonian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes memory leak issue with fusions.
Images
6 fusions in a row, compared to before where it started showing graphical issues at the 3rd fusion. Tested with 10 fusions in a row.
Issue(s) that this PR fixes
Fixes memory leak from #3603
Issue(s) that this PR does NOT fix
Item cursor issues from #3603. Even if you cancel using the item before even selecting a mon, the cursor still changes position, so I don't think it's related to the fusion process.
Discord contact info
AsparagusEduardo