Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static variable names #3637

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Fix static variable names #3637

merged 1 commit into from
Dec 8, 2023

Conversation

Bassoonian
Copy link
Collaborator

Fixes the name of some static variables that started with g to reflect their actual staticity.

Discord contact info

bassoonian

@Bassoonian Bassoonian added this to the 1.7.0 milestone Dec 6, 2023
@AsparagusEduardo
Copy link
Collaborator

This is not really 1.7-blocking I feel ^^;

mrgriffin
mrgriffin approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@mrgriffin mrgriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gOamDummyIndex was my fault, a leftover from when I was checking it in the tests I think ^^"

@Bassoonian
Copy link
Collaborator Author

Not very 1.7-blocking indeed, but I figured it was so stupidly small it deserved to go in too :P

@mrgriffin mrgriffin merged commit 97cb4cd into rh-hideout:upcoming Dec 8, 2023
1 check passed
@Bassoonian Bassoonian deleted the variablenamefix branch December 27, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgriffin mrgriffin mrgriffin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Bassoonian @AsparagusEduardo @mrgriffin