Fix HGSS Pokédex teachable moves list. #3624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The HGSS Pokédex is supposed to order the moves via TMs/HMs first and move-tutored moves after it. Because the list is merged into one in pokeemerald-expansion, this separation only happens with the icons themselves, which creates a visual bug where TMs/HMs/move-tutored moves end up having wrong TM names and icons assigned. This issue doesn't have a ticket currently.
This PR iterates the teachable moves list twice to collect TMs/HMs first out from it to keep the original grouping intact.
Discord contact info
graiondilach