ROM space on debug menu #3453
Merged
ROM space on debug menu #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe, yeah, by either unifying the functions or add a menu to check each individual aspect. |
Pushed a change so that "Free space: ..." is displayed everywhere now too:
|
AsparagusEduardo
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this Discord comment.
Currently 23.22MB/32MB on agbcc and 23.17MB/32MB on modern (GCC 13.2.0). Obviously a byte count like in the save block message would be completely useless. So I chose to round to two decimal places, with
ROUND_CEILINGbecause I think it's more annoying to think you have enough space and actually not, than the opposite.TBH it might make more sense to print out how much free space is available (both for the ROM and for save blocks)?