Fix test_runner.c modern warning #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Detect illegal opcodes in the test runner because mgba-rom-test evaluates them very slowly, making the TIMEOUT mechanism effectively realtime.
Silences a warning about an invalid pointer when building with modern.
SBird1337
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gTestRunnerState.test = __start_tests - 1;is UB. Rearranged the test runner code so that we can initialize to__start_testsinstead.Also:
modern-testdirectory so that you can switch betweenmake check MODERN=0andmake check MODERN=1.GBA:-prefixed lines, so that something like an illegal opcode error gets reported as belonging to the right test.Once this lands we should merge
masterwithupcomingso that we can switch to building withMODERN=1by default. The "CreateNPCTrainerPartyForTrainer generates customized Pokémon" test fails when built with modern, but not with agbcc. I haven't looked into this, and I don't think it's related to this PR(?)