Test cleanup and improvements #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alex <[email protected]>
Co-authored-by: Alex <[email protected]>
|
Ready for review :) |
Co-authored-by: Alex <[email protected]>
AlexOn1ine
reviewed
Oct 22, 2023
| } | ||
| } | ||
|
|
||
| SINGLE_BATTLE_TEST("Jaboca Berry is not triggered by a special move") | ||
| SINGLE_BATTLE_TEST("Jaboca Berry tirggers before Bug Bite can steal it") |
There was a problem hiding this comment.
Not sure what to do here since Bulbapedia and Showdown give conflicting information. Would be good if someone tested it in-game.
There was a problem hiding this comment.
For the record, we found that Showdown was wrong.
smogon/pokemon-showdown#9853
AlexOn1ine
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PARAMETRIZE.Discord contact info
AsparagusEduardo