Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix battle test estimateCost bug #3448

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Fix battle test estimateCost bug #3448

merged 1 commit into from
Oct 22, 2023

Conversation

mrgriffin
Copy link
Collaborator

As reported by @AsparagusEduardo here.

@mrgriffin mrgriffin changed the base branch from master to upcoming October 22, 2023 07:55
@mrgriffin
Copy link
Collaborator Author

If this gets approved we should make an identical PR to master :)

@AsparagusEduardo
Copy link
Collaborator

If this gets approved we should make an identical PR to master :)

Better yet, rebase this to master, because it fixes the issue there as well :)

@mrgriffin mrgriffin changed the base branch from upcoming to master October 22, 2023 12:44
@mrgriffin
Copy link
Collaborator Author

If this gets approved we should make an identical PR to master :)

Better yet, rebase this to master, because it fixes the issue there as well :)

Done!

@AsparagusEduardo AsparagusEduardo merged commit 8a6284c into rh-hideout:master Oct 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsparagusEduardo AsparagusEduardo AsparagusEduardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrgriffin @AsparagusEduardo