Fixes tests rng #3433
Merged
Fixes tests rng #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgriffin
previously approved these changes
Oct 19, 2023
|
Sent you a PR @AlexOn1ine with something that seems to fix the problem locally. Although I'm not convinced it's a proper fix, we might see this crop up again later :/ |
Seed before setUp
This should be good to go then |
mrgriffin
approved these changes
Oct 22, 2023
|
Did you guys test at different thread amounts? |
I tested 2 and 4. |
|
Passes for 1 and 8 too. |
|
Awesome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit to MGriffin