Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dka container for a more modern gcc #3429

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

SBird1337
Copy link
Collaborator

Switches the build environment in the CI to a DKP docker container.

Description

Seemed like one of the easiest ways to get an up to date arm toolchain, it's also what a lot of people use to build the project, so it should match the user environment as well as provide a modern toolchain.

Depends on #3428

Issue(s) that this PR fixes

/

Discord contact info

karathan

@AsparagusEduardo
Copy link
Collaborator

I think we need to update the INSTALL.md

@SBird1337
Copy link
Collaborator Author

I think we need to update the INSTALL.md

How so?

@SBird1337 SBird1337 force-pushed the env/dkp-ci branch 2 times, most recently from b9defe6 to 59cab5c Compare October 15, 2023 14:28
@AsparagusEduardo
Copy link
Collaborator

How so?

Don't we need to do that for the WSL instructions? Seeing that Ubuntu doesn't come with the latest gcc and collaborators and users could get frustrated on why their code works locally but not on CI

@SBird1337 SBird1337 marked this pull request as ready for review October 16, 2023 08:37
@SBird1337
Copy link
Collaborator Author

rebased to upcoming and set to ready. CI passes on gcc 13.2 :)

@AsparagusEduardo AsparagusEduardo merged commit 9ece7ed into rh-hideout:upcoming Oct 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants