Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new move flags and update all flags for every move #3425

Merged
merged 34 commits into from
Oct 19, 2023

Conversation

kittenchilly
Copy link

@kittenchilly kittenchilly commented Oct 14, 2023

Description

Adds these move flags, and replaces existing methods to use them:

  • twoTurnMove
  • forcePressure
  • cantUseTwice
  • healBlockBanned
  • encoreBanned
  • assistBanned
  • noParentalBondHit

And updates all flags for every move with ones that were missing, comparing to pokemon showdown data and a datamined SV spreadsheet. This should fix a few move related bugs that were overlooked.
Additionally updates Grassy Glide's gen 9 BP to 55 as it was changed in Teal Mask.

Discord contact info

kittenchilly

Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look at the battle_moves.h changes now, but for now I have some comments.

test/battle/ability/pressure.c Outdated Show resolved Hide resolved
test/battle/move_flags/cant_use_twice.c Outdated Show resolved Hide resolved
test/battle/move_flags/cant_use_twice.c Show resolved Hide resolved
test/battle/move_flags/cant_use_twice.c Outdated Show resolved Hide resolved
test/battle/move_flags/cant_use_twice.c Outdated Show resolved Hide resolved
include/pokemon.h Outdated Show resolved Hide resolved
include/pokemon.h Outdated Show resolved Hide resolved
src/battle_ai_main.c Show resolved Hide resolved
@kittenchilly
Copy link
Author

All reviews checked and applied

src/data/battle_moves.h Outdated Show resolved Hide resolved
@AsparagusEduardo AsparagusEduardo merged commit 33a0fdb into rh-hideout:upcoming Oct 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants