forked from DizzyEggg/pokeemerald
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new move flags and update all flags for every move #3425
Merged
AsparagusEduardo
merged 34 commits into
rh-hideout:upcoming
from
kittenchilly:moveflags
Oct 19, 2023
Merged
Add new move flags and update all flags for every move #3425
AsparagusEduardo
merged 34 commits into
rh-hideout:upcoming
from
kittenchilly:moveflags
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsparagusEduardo
requested changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a look at the battle_moves.h
changes now, but for now I have some comments.
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
All reviews checked and applied |
AsparagusEduardo
requested changes
Oct 19, 2023
AsparagusEduardo
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds these move flags, and replaces existing methods to use them:
And updates all flags for every move with ones that were missing, comparing to pokemon showdown data and a datamined SV spreadsheet. This should fix a few move related bugs that were overlooked.
Additionally updates Grassy Glide's gen 9 BP to 55 as it was changed in Teal Mask.
Discord contact info
kittenchilly