Removed pointless for loop in CB2_InitBattleInternal #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsparagusEduardo
requested changes
Oct 14, 2023
It's a correction. Since it's not a new feature I figured Master was the right place for it? Whatever, I don't care. Will rebase. |
|
To put it on record, I see code cleanup as part of upcoming. |
LOuroboros
force-pushed
the
LOuroboros-patch-1
branch
from
e3e6b2e
to
106cd58
Compare
AsparagusEduardo
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Title.
Yesterday, I was looking at
CB2_InitBattleInternalfor reasons and I noticed that it was running 2 for loops to apply changes on the Pokémon in the Player's and the Opponent's parties.However, it only really needs to run 1, as far as I can tell.
This PR corrects that.
Discord contact info
lunos4026