Converted Get(Box)MonData2 to proper functions

[AsparagusEduardo]

Description

Fixing a potential issue found by @Pawkkie, where using Get(Box)MonData in a macro caused issues without a NULL as the 3rd argument.

eg.

#define CALC_STAT(base, iv, ev, statIndex, field)               \
{                                                               \
    u8 baseStat = gSpeciesInfo[species].base;                   \
    s32 n = (((2 * baseStat + iv + ev / 4) * level) / 100) + 5; \
-   u8 nature = GetNature(mon);                                 \
+   u8 nature = GetMonData(mon, MON_DATA_NATURE);               \
    n = ModifyStatByNature(nature, n, statIndex);               \
    if (B_FRIENDSHIP_BOOST == TRUE)                             \
        n = n + ((n * 10 * friendship) / (MAX_FRIENDSHIP * 100));\
    SetMonData(mon, field, &n);                                 \
}

Discord message: https://discord.com/channels/419213663107416084/1077168246555430962/1162529804894085151

Images

Discord contact info

AsparagusEduardo