Fix Wall Werrors on modern #3412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBird1337
requested changes
Oct 13, 2023
|
When doing things like StoreWordInTwoHalfwords((u16*) &task->tExitCallback, (intptr_t)exitCallback);I think this is still technically UB 🤔 |
Co-authored-by: Philipp AUER <[email protected]>
Co-authored-by: Philipp AUER <[email protected]>
Co-authored-by: Philipp AUER <[email protected]>
Co-authored-by: Philipp AUER <[email protected]>
Co-authored-by: Philipp AUER <[email protected]>
I ain't gonna fix GF's code xD |
SBird1337
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #3267
With Edu's PR merged to PRET this was fairly straightforward, it's more or less the same as the previous PR.
The only major change I did, compared to before, is that I kept the
-Wno-strict-aliasingflag to not have to do weird memcpy shenanigans.Tests and hgss dex should be working too.