Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for 6 more abilities #3399

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Tests for 6 more abilities #3399

merged 4 commits into from
Oct 13, 2023

Conversation

Bassoonian
Copy link
Collaborator

@Bassoonian Bassoonian commented Oct 10, 2023 •
edited
Loading

Sorry Eduardo! :)

Description

Adds tests for the following six abilities:

  • Sharpness
  • Purifying Salt
  • Ice Scales
  • Neuroforce
  • Beast Boost
  • Quick Draw

Also fixes the following bugs:

  • Quick Draw now uses weighted RNG
  • Purifying Salt makes Rest fail

It also updates Leaf Guard's test to be in line with Purifying Salt's (see Discord & the reviews)

Discord contact info

bassoonian

DizzyEggg
DizzyEggg requested changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@DizzyEggg DizzyEggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :)

test/battle/ability/beast_boost.c Outdated Show resolved Hide resolved
test/battle/ability/ice_scales.c Outdated Show resolved Hide resolved
test/battle/ability/ice_scales.c Show resolved Hide resolved
test/battle/ability/neuroforce.c Show resolved Hide resolved
test/battle/ability/purifying_salt.c Show resolved Hide resolved
test/battle/ability/sharpness.c Show resolved Hide resolved
test/battle/ability/ice_scales.c Show resolved Hide resolved
DizzyEggg
DizzyEggg requested changes Oct 10, 2023
View reviewed changes
test/battle/ability/purifying_salt.c Outdated Show resolved Hide resolved
DizzyEggg
DizzyEggg requested changes Oct 12, 2023
View reviewed changes
test/battle/ability/purifying_salt.c Show resolved Hide resolved
test/battle/ability/leaf_guard.c Show resolved Hide resolved
@DizzyEggg DizzyEggg closed this Oct 13, 2023
@DizzyEggg DizzyEggg reopened this Oct 13, 2023
@DizzyEggg DizzyEggg merged commit 231ebea into rh-hideout:master Oct 13, 2023
1 check passed
@Bassoonian Bassoonian deleted the evenmorebattletests branch October 24, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DizzyEggg DizzyEggg DizzyEggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bassoonian @DizzyEggg